Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add seedrandom dep to resolutions #12552

Merged
merged 2 commits into from
May 23, 2024
Merged

Add seedrandom dep to resolutions #12552

merged 2 commits into from
May 23, 2024

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented May 23, 2024

... to shut renovate up.

Followup on #12501 (comment)

... to shut renovate up
@richvdh richvdh requested a review from a team as a code owner May 23, 2024 12:30
@richvdh richvdh added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label May 23, 2024
@richvdh richvdh requested a review from florianduros May 23, 2024 12:30
If we just declare it in `resolutions`, it doesn't get installed at all,
because it is only a devDependency of `bloom-filters`.
@richvdh
Copy link
Member Author

richvdh commented May 23, 2024

@t3chguy could you look at this and check it's what you had in mind?

@richvdh richvdh requested a review from t3chguy May 23, 2024 15:23
@richvdh richvdh changed the title Move seedrandom dep to resolutions Add seedrandom dep to resolutions May 23, 2024
@t3chguy
Copy link
Member

t3chguy commented May 23, 2024

Was hoping just resolutions was enough but I guess the other package is extra broken

@richvdh richvdh added this pull request to the merge queue May 23, 2024
Merged via the queue into develop with commit bc48fe4 May 23, 2024
34 checks passed
@richvdh richvdh deleted the rav/seedrandom_dep branch May 23, 2024 21:02
thoraj added a commit to verji/matrix-react-sdk that referenced this pull request Aug 15, 2024
* Upgrade dependency to [email protected]

* v3.100.0-rc.0

* Upgrade dependency to [email protected]

* Remove code smell assertion identified by Sonar (matrix-org#12547)

* This assertion is unnecessary since the receiver accepts the original type of the expression

* Implement `client.getDomain()` null check

* Update comment since `AutoDiscovery.findClientConfig` may still throw

* Report verification and recovery state to posthog (matrix-org#12516)

* Report verification and recovery state to posthog

* Fix CryptoApi import

* Fix js-sdk import

* Review: Use DeviceVerificationStatus instead of CrossSigningStatus

* Review: Clean condition to check secrets in 4S

* review: Fix redundent !!

* Deprecate `Tooltip.tsx`

* Use tooltip compound in `MessageComposer.tsx`

* Use tooltip compound in `ReadReceiptGroup` component

* Use tooltip compound in `ReadReceiptPerson` component

* Delete `useTooltip.tsx`

* Use compound tooltip in `ReactionRowButton`

* Upgrade dependency to [email protected]

* Migrate `TooltipTarget` usage to compound `Tooltip` (matrix-org#12542)

* Use new tooltip in `RoomTopic.tsx`

* Use new tooltip in `MLocationBody.tsx`

* Fix room topic

* Update location snapshot

* Use new tooltip in `AppPermission.tsx`

* Remove `TooltipTarget`

* Add tests for `RoomTopic`

* Add tests for `ReadReceiptGroup.tsx`

* Add more tests for `ReadReceiptGroup.tsx`

* Add more test for `ReactionsRowButton.tsx`

* Add seedrandom dep to `resolutions` (matrix-org#12552)

* Move seedrandom dep to `resolutions`

... to shut renovate up

* Reinstate `seedrandom` as dev dependency

If we just declare it in `resolutions`, it doesn't get installed at all,
because it is only a devDependency of `bloom-filters`.

* [create-pull-request] automated change (matrix-org#12554)

Co-authored-by: github-merge-queue <[email protected]>

* Avoid using deprecated exports, fields, and duplicate code (matrix-org#12555)

* Fix tabbedview breakpoint width (matrix-org#12556)

Which should be 1024 according to the designs, not 768

* Tooltip: close field tooltip when ESC is pressed (matrix-org#12553)

* Close field tooltip when ESC is pressed

* Use `Key.ESCAPE`

* Close the release announcement when a dialog is opened (matrix-org#12559)

* Fire `ModalManagerEvent.Closed` when a dialog is closed

* Listen to modal events in the RA

* Fix first RA test

* Upgrade dependency to [email protected]

* v3.100.0-rc.1

* Upgrade dependency to [email protected]

* v3.100.0

---------

Co-authored-by: RiotRobot <[email protected]>
Co-authored-by: Ed Geraghty <[email protected]>
Co-authored-by: Valere <[email protected]>
Co-authored-by: Florian Duros <[email protected]>
Co-authored-by: Florian Duros <[email protected]>
Co-authored-by: David Baker <[email protected]>
Co-authored-by: Richard van der Hoff <[email protected]>
Co-authored-by: github-merge-queue <[email protected]>
Co-authored-by: Michael Telatynski <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants